diff options
| author | Steve Glendinning <steve.glendinning@smsc.com> | 2009-02-16 08:46:06 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-20 09:35:08 +0100 |
| commit | 9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b (patch) | |
| tree | d0262254d16becb4867cf6883108b3998891e123 /drivers/net/smsc9420.c | |
| parent | wimax/i2400m: driver loads firmware v1.4 instead of v1.3 (diff) | |
| download | linux-9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b.tar.xz linux-9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b.zip | |
smsc9420: fix another postfixed timeout
Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards. This patch fixes another, so the timeout
will be correctly detected and a warning printed.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/smsc9420.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c index a1e4b3895b33..83938e1953b0 100644 --- a/drivers/net/smsc9420.c +++ b/drivers/net/smsc9420.c @@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op) do { msleep(1); e2cmd = smsc9420_reg_read(pd, E2P_CMD); - } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--)); + } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout)); if (!timeout) { smsc_info(HW, "TIMED OUT"); |