diff options
| author | Hangbin Liu <liuhangbin@gmail.com> | 2018-11-22 09:15:28 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-11-24 02:18:15 +0100 |
| commit | 5ed9dc99107144f83b6c1bb52a69b58875baf540 (patch) | |
| tree | 438ec2a7d4d3fc051ed9ecf1581439f59c081c70 /drivers/net/team | |
| parent | virtio-net: fail XDP set if guest csum is negotiated (diff) | |
| download | linux-5ed9dc99107144f83b6c1bb52a69b58875baf540.tar.xz linux-5ed9dc99107144f83b6c1bb52a69b58875baf540.zip | |
team: no need to do team_notify_peers or team_mcast_rejoin when disabling port
team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
will send multicast join group message to notify peers. We should do this when
enabling/changed to a new port. But it doesn't make sense to do it when a port
is disabled.
On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
4 mcast rejoin messages at latest, which will make user confused. The same
with notify_peers.count.
Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
team_port_disable().
Reported-by: Liang Li <liali@redhat.com>
Fixes: fc423ff00df3a ("team: add peer notification")
Fixes: 492b200efdd20 ("team: add support for sending multicast rejoins")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/team')
| -rw-r--r-- | drivers/net/team/team.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index db633ae9f784..364f514d56d8 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -985,8 +985,6 @@ static void team_port_disable(struct team *team, team->en_port_count--; team_queue_override_port_del(team, port); team_adjust_ops(team); - team_notify_peers(team); - team_mcast_rejoin(team); team_lower_state_changed(port); } |