summaryrefslogtreecommitdiffstats
path: root/drivers/net/tulip
diff options
context:
space:
mode:
authorGrant Likely <grant.likely@secretlab.ca>2008-01-25 06:25:31 +0100
committerGrant Likely <grant.likely@secretlab.ca>2008-01-26 23:32:19 +0100
commit4fb4c5582475452d3bf7c5072ef2d15ee06f7723 (patch)
tree9e75d2795deafb6601fb31c858874ebd554a4135 /drivers/net/tulip
parent[POWERPC] Add common clock setting routine mpc52xx_psc_set_clkdiv() (diff)
downloadlinux-4fb4c5582475452d3bf7c5072ef2d15ee06f7723.tar.xz
linux-4fb4c5582475452d3bf7c5072ef2d15ee06f7723.zip
[POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm
It is dangerous for an mpc52xx device driver to modify the port_config register. If the driver is probed incorrectly, it will change the pin IO configuration in ways which may not be compatible with the board. port_config should be set up by the bootloader, or failing that, in the platform setup code in arch/powerpc/platforms/52xx. Also, modifying CDM registers directly can cause a race condition with other drivers. Instead call a common routine to modify CDM settings. Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Acked-by: Dragos Carp <dragos.carp@toptica.com>
Diffstat (limited to 'drivers/net/tulip')
0 files changed, 0 insertions, 0 deletions