summaryrefslogtreecommitdiffstats
path: root/drivers/net/typhoon.c
diff options
context:
space:
mode:
authorGrant Grundler <grundler@parisc-linux.org>2008-04-21 06:44:15 +0200
committerJeff Garzik <jgarzik@redhat.com>2008-04-25 08:08:08 +0200
commit5a0e2cd51145748c4fd44d0c3a06d39eb87e8725 (patch)
tree5a2b725da88ac6b0dc3bae16fbe387daef206686 /drivers/net/typhoon.c
parentibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround (diff)
downloadlinux-5a0e2cd51145748c4fd44d0c3a06d39eb87e8725.tar.xz
linux-5a0e2cd51145748c4fd44d0c3a06d39eb87e8725.zip
[netdrvr] typhoon: typhoon_resume - remove call to start_queue
While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952 I looked at a few other drivers to figure out what drivers _should_ be doing for suspend/resume. I noticed typhoon driver is likely doing more than it needs to. Patch below is untested since I don't have the HW. Suspend/resume code across NIC drivers is fairly inconsistent. And I couldn't find any documentation on what the canonical sequence NICs need to do for suspend or resume. Is there any? Barring contrary advice, I'm going model the tulip suspend/resume fixes after tg3.c since a number of "modern" (< 5 years old) laptops have that and I'm silly enough to assume it works. Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/typhoon.c')
-rw-r--r--drivers/net/typhoon.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 333961bb7873..c0dd25ba7a18 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
}
netif_device_attach(dev);
- netif_start_queue(dev);
return 0;
reset: