diff options
| author | Ben Dooks <ben.dooks@codethink.co.uk> | 2018-10-11 15:03:32 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-11 21:06:06 +0200 |
| commit | 8cc1da96d1c92aad27b7dfd689b3cdcc6a2bcc18 (patch) | |
| tree | 94d40876671a450d84edc8e8e977c56ee0bfcada /drivers/net/usb/cdc_ncm.c | |
| parent | selftests: use posix-style redirection in ip_defrag.sh (diff) | |
| download | linux-8cc1da96d1c92aad27b7dfd689b3cdcc6a2bcc18.tar.xz linux-8cc1da96d1c92aad27b7dfd689b3cdcc6a2bcc18.zip | |
net: cdc_ncm: use tasklet_init() for tasklet_struct init
The tasklet initialisation would be better done by tasklet_init()
instead of assuming all the fields are in an ok state by default.
This does not fix any actual know bug.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/cdc_ncm.c')
| -rw-r--r-- | drivers/net/usb/cdc_ncm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 1eaec648bd1f..35a7d61453d5 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -779,8 +779,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_ hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); ctx->tx_timer.function = &cdc_ncm_tx_timer_cb; - ctx->bh.data = (unsigned long)dev; - ctx->bh.func = cdc_ncm_txpath_bh; + tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long)dev); atomic_set(&ctx->stop, 0); spin_lock_init(&ctx->mtx); |