diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2022-02-21 18:34:15 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-02-23 02:00:54 +0100 |
| commit | cc727b6418004e90e1fea04d70f95e97dcf45331 (patch) | |
| tree | 1c6b162adcd1d5df60fe3daa1f45a0824f9c9db2 /drivers/net/usb/gl620a.c | |
| parent | net: phy: phylink: fix DSA mac_select_pcs() introduction (diff) | |
| download | linux-cc727b6418004e90e1fea04d70f95e97dcf45331.tar.xz linux-cc727b6418004e90e1fea04d70f95e97dcf45331.zip | |
usbnet: gl620a: Replace one-element array with flexible-array member
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().
This issue was found with the help of Coccinelle and audited and fixed,
manually.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20220221173415.GA1149599@embeddedor
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/usb/gl620a.c')
| -rw-r--r-- | drivers/net/usb/gl620a.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/gl620a.c b/drivers/net/usb/gl620a.c index 13a9a83b8538..46af78caf457 100644 --- a/drivers/net/usb/gl620a.c +++ b/drivers/net/usb/gl620a.c @@ -56,7 +56,7 @@ struct gl_packet { __le32 packet_length; - char packet_data [1]; + char packet_data[]; }; struct gl_header { |