diff options
| author | George Kennedy <george.kennedy@oracle.com> | 2020-07-15 15:59:31 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2020-07-16 03:26:29 +0200 |
| commit | c28d9a285668c799eeae2f7f93e929a6028a4d6d (patch) | |
| tree | 041736eedabc0d754aa0e4fe137127f31b505561 /drivers/net/usb | |
| parent | vsock/virtio: annotate 'the_virtio_vsock' RCU pointer (diff) | |
| download | linux-c28d9a285668c799eeae2f7f93e929a6028a4d6d.tar.xz linux-c28d9a285668c799eeae2f7f93e929a6028a4d6d.zip | |
ax88172a: fix ax88172a_unbind() failures
If ax88172a_unbind() fails, make sure that the return code is
less than zero so that cleanup is done properly and avoid UAF.
Fixes: a9a51bd727d1 ("ax88172a: fix information leak on short answers")
Signed-off-by: George Kennedy <george.kennedy@oracle.com>
Reported-by: syzbot+4cd84f527bf4a10fc9c1@syzkaller.appspotmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/ax88172a.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c index 4e514f5d7c6c..fd3a04d98dc1 100644 --- a/drivers/net/usb/ax88172a.c +++ b/drivers/net/usb/ax88172a.c @@ -187,6 +187,7 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf) ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, ETH_ALEN, buf, 0); if (ret < ETH_ALEN) { netdev_err(dev->net, "Failed to read MAC address: %d\n", ret); + ret = -EIO; goto free; } memcpy(dev->net->dev_addr, buf, ETH_ALEN); |