diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2010-06-30 04:47:40 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-06-30 23:09:36 +0200 |
| commit | cbf2d604a1cd77944a795bb8dbe844eaa38b44c8 (patch) | |
| tree | 2881f953ac36d6fbf6662ad3264babe5303685db /drivers/net/vmxnet3 | |
| parent | netdev: Make ethtool_ops::set_flags() return -EINVAL for unsupported flags (diff) | |
| download | linux-cbf2d604a1cd77944a795bb8dbe844eaa38b44c8.tar.xz linux-cbf2d604a1cd77944a795bb8dbe844eaa38b44c8.zip | |
vmxnet3: Remove incorrect implementation of ethtool_ops::get_flags()
Only some netdev feature flags correspond directly to ethtool feature
flags. ethtool_op_get_flags() does the right thing.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vmxnet3')
| -rw-r--r-- | drivers/net/vmxnet3/vmxnet3_ethtool.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c index 8a71a21d53ec..de1ba148171e 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c @@ -275,12 +275,6 @@ vmxnet3_get_strings(struct net_device *netdev, u32 stringset, u8 *buf) } } -static u32 -vmxnet3_get_flags(struct net_device *netdev) -{ - return netdev->features; -} - static int vmxnet3_set_flags(struct net_device *netdev, u32 data) { @@ -559,7 +553,7 @@ static struct ethtool_ops vmxnet3_ethtool_ops = { .get_tso = ethtool_op_get_tso, .set_tso = ethtool_op_set_tso, .get_strings = vmxnet3_get_strings, - .get_flags = vmxnet3_get_flags, + .get_flags = ethtool_op_get_flags, .set_flags = vmxnet3_set_flags, .get_sset_count = vmxnet3_get_sset_count, .get_ethtool_stats = vmxnet3_get_ethtool_stats, |