diff options
| author | Jiri Benc <jbenc@redhat.com> | 2017-04-27 21:24:36 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-01 04:30:13 +0200 |
| commit | baf4d7860771287f30fbe9b6b2dc18b04361439d (patch) | |
| tree | d67b515cb3a68a29cf5132a94f1be454fc6c5264 /drivers/net/vxlan.c | |
| parent | vxlan: correctly handle ipv6.disable module parameter (diff) | |
| download | linux-baf4d7860771287f30fbe9b6b2dc18b04361439d.tar.xz linux-baf4d7860771287f30fbe9b6b2dc18b04361439d.zip | |
vxlan: do not output confusing error message
The message "Cannot bind port X, err=Y" creates only confusion. In metadata
based mode, failure of IPv6 socket creation is okay if IPv6 is disabled and
no error message should be printed. But when IPv6 tunnel was requested, such
failure is fatal. The vxlan_socket_create does not know when the error is
harmless and when it's not.
Instead of passing such information down to vxlan_socket_create, remove the
message completely. It's not useful. We propagate the error code up to the
user space and the port number comes from the user space. There's nothing in
the message that the process creating vxlan interface does not know.
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vxlan.c')
| -rw-r--r-- | drivers/net/vxlan.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 84a86cbb31b9..328b4712683c 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2758,8 +2758,6 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, bool ipv6, sock = vxlan_create_sock(net, ipv6, port, flags); if (IS_ERR(sock)) { - pr_info("Cannot bind port %d, err=%ld\n", ntohs(port), - PTR_ERR(sock)); kfree(vs); return ERR_CAST(sock); } |