diff options
author | Krzysztof Halasa <khc@pm.waw.pl> | 2006-06-22 22:29:28 +0200 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2006-06-23 05:32:03 +0200 |
commit | 4446065a2c9b65398ceb115f4d8c256eb1bb9647 (patch) | |
tree | cdaa04d42876632e0df95054d46851cac6648ce3 /drivers/net/wan/c101.c | |
parent | [PATCH] WAN: register_hdlc_device() doesn't need dev_alloc_name() (diff) | |
download | linux-4446065a2c9b65398ceb115f4d8c256eb1bb9647.tar.xz linux-4446065a2c9b65398ceb115f4d8c256eb1bb9647.zip |
[PATCH] WAN: ioremap() failure checks in drivers
Eric Sesterhenn found that pci200syn initialization lacks return
statement in ioremap() error path (coverity bug id #195). It looks
like more WAN drivers have problems with ioremap().
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/wan/c101.c')
-rw-r--r-- | drivers/net/wan/c101.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 43d854ace233..b60ef02db7b0 100644 --- a/drivers/net/wan/c101.c +++ b/drivers/net/wan/c101.c @@ -326,21 +326,21 @@ static int __init c101_run(unsigned long irq, unsigned long winbase) if (request_irq(irq, sca_intr, 0, devname, card)) { printk(KERN_ERR "c101: could not allocate IRQ\n"); c101_destroy_card(card); - return(-EBUSY); + return -EBUSY; } card->irq = irq; if (!request_mem_region(winbase, C101_MAPPED_RAM_SIZE, devname)) { printk(KERN_ERR "c101: could not request RAM window\n"); c101_destroy_card(card); - return(-EBUSY); + return -EBUSY; } card->phy_winbase = winbase; card->win0base = ioremap(winbase, C101_MAPPED_RAM_SIZE); if (!card->win0base) { printk(KERN_ERR "c101: could not map I/O address\n"); c101_destroy_card(card); - return -EBUSY; + return -EFAULT; } card->tx_ring_buffers = TX_RING_BUFFERS; |