diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2010-11-25 00:27:55 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-11-29 23:51:54 +0100 |
| commit | 6a20bd45fda271bd57e3ba41b3de3009797f4b5e (patch) | |
| tree | d0699ec589106045e082b8fd7035860b616d1cbd /drivers/net/wan/x25_asy.c | |
| parent | TTY: ldisc, fix open flag handling (diff) | |
| download | linux-6a20bd45fda271bd57e3ba41b3de3009797f4b5e.tar.xz linux-6a20bd45fda271bd57e3ba41b3de3009797f4b5e.zip | |
NET: wan/x25, fix ldisc->open retval
We should never return positive values from ldisc->open, tty layer
doesn't (and never did) expect that.
If we do that, weird things like warnings in tty_ldisc_close happen.
Not sure if dev->base_addr is used somehow now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>
Cc: linux-x25@vger.kernel.org
Tested-by: Sergey Lapin <slapin@ossfans.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/net/wan/x25_asy.c')
| -rw-r--r-- | drivers/net/wan/x25_asy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index d81ad8397885..66cda25aaa26 100644 --- a/drivers/net/wan/x25_asy.c +++ b/drivers/net/wan/x25_asy.c @@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty) if (err) return err; /* Done. We have linked the TTY line to a channel. */ - return sl->dev->base_addr; + return 0; } |