diff options
| author | Cindy H Kao <cindy.h.kao@intel.com> | 2010-04-09 01:03:12 +0200 |
|---|---|---|
| committer | Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> | 2010-05-11 23:05:47 +0200 |
| commit | 2354161dd33b204d36caa0bc48c95cc6c1a984fb (patch) | |
| tree | 7d1606bfef35ae72dfb823be860ed6b67e9c67ba /drivers/net/wimax/i2400m | |
| parent | wimax/i2400m: add the error recovery mechanism on TX path (diff) | |
| download | linux-2354161dd33b204d36caa0bc48c95cc6c1a984fb.tar.xz linux-2354161dd33b204d36caa0bc48c95cc6c1a984fb.zip | |
wimax/i2400m: Correct the error path handlers order in i2400m_post_reset()
When bus_setup fails in i2400m_post_reset(), it falls to the error path handler
"error_bus_setup:" which includes unlock the mutext. However, we didn't ever
try to the obtain the lock when running bus_setup.
The patch is to fix the misplaced error path handler "error_bus_setup:".
Signed-off-by: Cindy H Kao <cindy.h.kao@intel.com>
Diffstat (limited to 'drivers/net/wimax/i2400m')
| -rw-r--r-- | drivers/net/wimax/i2400m/driver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c index d83fe84407bf..39cf96a90d7a 100644 --- a/drivers/net/wimax/i2400m/driver.c +++ b/drivers/net/wimax/i2400m/driver.c @@ -629,12 +629,12 @@ int i2400m_post_reset(struct i2400m *i2400m) error_dev_start: if (i2400m->bus_release) i2400m->bus_release(i2400m); -error_bus_setup: /* even if the device was up, it could not be recovered, so we * mark it as down. */ i2400m->updown = 0; wmb(); /* see i2400m->updown's documentation */ mutex_unlock(&i2400m->init_mutex); +error_bus_setup: d_fnend(3, dev, "(i2400m %p) = %d\n", i2400m, result); return result; } |