diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2015-10-25 14:57:06 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-10-27 06:08:12 +0100 |
commit | 81a577034b000964ca791281a975f0ba9a9d7eed (patch) | |
tree | 6b9cd46df844a495955d7ed46ab9521f9eb3e1a6 /drivers/net/wireless/ath/ath6kl | |
parent | net: phy: mdio: add missing of_node_put (diff) | |
download | linux-81a577034b000964ca791281a975f0ba9a9d7eed.tar.xz linux-81a577034b000964ca791281a975f0ba9a9d7eed.zip |
ath6kl: add missing of_node_put
for_each_compatible_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
expression e;
local idexpression n;
@@
for_each_compatible_node(n,...) {
... when != of_node_put(n)
when != e = n
(
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireless/ath/ath6kl')
-rw-r--r-- | drivers/net/wireless/ath/ath6kl/init.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6e473fa4b13c..12241b1c57cd 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c @@ -715,6 +715,7 @@ static bool check_device_tree(struct ath6kl *ar) board_filename, ret); continue; } + of_node_put(node); return true; } return false; |