summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/hostap/hostap_info.c
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2012-08-23 09:16:44 +0200
committerJohn W. Linville <linville@tuxdriver.com>2012-09-07 21:03:38 +0200
commitc3a2ee93501645fe9ceeb02335f8d8512770e972 (patch)
tree2bc2c9deceb9e833af583e137c2b26c514c9f534 /drivers/net/wireless/hostap/hostap_info.c
parentorinoco: use is_zero_ether_addr() instead of memcmp() (diff)
downloadlinux-c3a2ee93501645fe9ceeb02335f8d8512770e972.tar.xz
linux-c3a2ee93501645fe9ceeb02335f8d8512770e972.zip
drivers/net: use is_zero_ether_addr() instead of memcmp()
Using is_zero_ether_addr() instead of directly use memcmp() to determine if the ethernet address is all zeros. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/hostap/hostap_info.c')
-rw-r--r--drivers/net/wireless/hostap/hostap_info.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/hostap/hostap_info.c b/drivers/net/wireless/hostap/hostap_info.c
index 47932b28aac1..970a48baaf80 100644
--- a/drivers/net/wireless/hostap/hostap_info.c
+++ b/drivers/net/wireless/hostap/hostap_info.c
@@ -4,6 +4,7 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/export.h>
+#include <linux/etherdevice.h>
#include "hostap_wlan.h"
#include "hostap.h"
#include "hostap_ap.h"
@@ -463,8 +464,7 @@ static void handle_info_queue_scanresults(local_info_t *local)
prism2_host_roaming(local);
if (local->host_roaming == 2 && local->iw_mode == IW_MODE_INFRA &&
- memcmp(local->preferred_ap, "\x00\x00\x00\x00\x00\x00",
- ETH_ALEN) != 0) {
+ !is_zero_ether_addr(local->preferred_ap)) {
/*
* Firmware seems to be getting into odd state in host_roaming
* mode 2 when hostscan is used without join command, so try