diff options
| author | Zhengchao Shao <shaozhengchao@huawei.com> | 2022-12-09 02:24:22 +0100 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2022-12-22 17:05:17 +0100 |
| commit | 9fe21dc626117fb44a8eb393713a86a620128ce3 (patch) | |
| tree | 3ee8c6f5a72962ba22bc22a47476fe7c891e1be3 /drivers/net/wireless/intel/ipw2x00 | |
| parent | wifi: ipw2x00: don't call dev_kfree_skb() under spin_lock_irqsave() (diff) | |
| download | linux-9fe21dc626117fb44a8eb393713a86a620128ce3.tar.xz linux-9fe21dc626117fb44a8eb393713a86a620128ce3.zip | |
wifi: ipw2200: fix memory leak in ipw_wdev_init()
In the error path of ipw_wdev_init(), exception value is returned, and
the memory applied for in the function is not released. Also the memory
is not released in ipw_pci_probe(). As a result, memory leakage occurs.
So memory release needs to be added to the error path of ipw_wdev_init().
Fixes: a3caa99e6c68 ("libipw: initiate cfg80211 API conversion (v2)")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221209012422.182669-1-shaozhengchao@huawei.com
Diffstat (limited to 'drivers/net/wireless/intel/ipw2x00')
| -rw-r--r-- | drivers/net/wireless/intel/ipw2x00/ipw2200.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index cc66fd92278e..d382f2017325 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -11383,9 +11383,14 @@ static int ipw_wdev_init(struct net_device *dev) set_wiphy_dev(wdev->wiphy, &priv->pci_dev->dev); /* With that information in place, we can now register the wiphy... */ - if (wiphy_register(wdev->wiphy)) - rc = -EIO; + rc = wiphy_register(wdev->wiphy); + if (rc) + goto out; + + return 0; out: + kfree(priv->ieee->a_band.channels); + kfree(priv->ieee->bg_band.channels); return rc; } |