diff options
author | Daniel Mack <daniel@caiaq.de> | 2009-12-16 05:12:58 +0100 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-12-21 17:32:24 +0100 |
commit | 45b241689179a6065384260242637cf21dabfb2d (patch) | |
tree | 6a5a89b3a98db2f1876b772e8d078e315e389f0b /drivers/net/wireless/iwmc3200wifi/netdev.c | |
parent | drivers/net/wireless/iwlwifi/iwl-tx.c: fix gcc-3.4.5 warning (diff) | |
download | linux-45b241689179a6065384260242637cf21dabfb2d.tar.xz linux-45b241689179a6065384260242637cf21dabfb2d.zip |
Libertas: fix buffer overflow in lbs_get_essid()
The libertas driver copies the SSID buffer back to the wireless core and
appends a trailing NULL character for termination. This is
a) unnecessary because the buffer is allocated with kzalloc and is hence
already NULLed when this function is called, and
b) for priv->curbssparams.ssid_len == 32, it writes back one byte too
much which causes memory corruptions.
Fix this by removing the extra write.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Maithili Hinge <maithili@marvell.com>
Cc: Kiran Divekar <dkiran@marvell.com>
Cc: Michael Hirsch <m.hirsch@raumfeld.com>
Cc: netdev@vger.kernel.org
Cc: libertas-dev@lists.infradead.org
Cc: linux-wireless@lists.infradead.org
Cc: stable@kernel.org
Acked-by: Holger Schurig <holgerschurig@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwmc3200wifi/netdev.c')
0 files changed, 0 insertions, 0 deletions