diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2014-11-19 18:51:55 +0100 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2014-11-19 18:51:55 +0100 |
| commit | 6b67e01fc0c4f7759a3e6e75fdcf17195daa482e (patch) | |
| tree | b5f0e38f20f94623a145969c4689e68117dcca92 /drivers/net/wireless/mac80211_hwsim.c | |
| parent | mac80211-hwsim: hwname is always known so use the value from wiphy (diff) | |
| download | linux-6b67e01fc0c4f7759a3e6e75fdcf17195daa482e.tar.xz linux-6b67e01fc0c4f7759a3e6e75fdcf17195daa482e.zip | |
mac80211-hwsim: remove unnecessary hwname check
The hwname will always be set if idx is negative (as it's
a u32 read into an s64 it can't overflow either) so we can
remove the unnecessary check for hwname being non-NULL.
This was reported by smatch.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net/wireless/mac80211_hwsim.c')
| -rw-r--r-- | drivers/net/wireless/mac80211_hwsim.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index bbbcc4d8bb91..c88a21acda64 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -2808,8 +2808,7 @@ static int hwsim_del_radio_nl(struct sk_buff *msg, struct genl_info *info) if (data->idx != idx) continue; } else { - if (hwname && - strcmp(hwname, wiphy_name(data->hw->wiphy))) + if (strcmp(hwname, wiphy_name(data->hw->wiphy))) continue; } |