summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/rt2x00/rt2800pci.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-01-12 07:34:50 +0100
committerJohn W. Linville <linville@tuxdriver.com>2012-01-13 20:40:56 +0100
commit92c1ff1fa772ee76a18ae1edd2e4baecf381f17e (patch)
tree1e92c04b64bb3ac4e8d2424e854ef6e9301a8be9 /drivers/net/wireless/rt2x00/rt2800pci.c
parentwireless: b43: fix Oops on card eject during transfer (diff)
downloadlinux-92c1ff1fa772ee76a18ae1edd2e4baecf381f17e.tar.xz
linux-92c1ff1fa772ee76a18ae1edd2e4baecf381f17e.zip
ipw2x00: signedness bug handling frame length
This is basically just a cleanup. Large positive numbers get counted as negative but then get implicitly cast to positive again for the checks that matter. This does make a small difference in ipw_handle_promiscuous_rx() when we test "if (unlikely((len + IPW_RX_FRAME_SIZE) > skb_tailroom(rxb->skb)))" It should return there, but we don't return until a couple lines later when we test "if (len > IPW_RX_BUF_SIZE - sizeof(struct ipw_rt_hdr)) {". The difference is that in the second test the sizeof() means that there is an implied cast to unsigned. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/rt2x00/rt2800pci.c')
0 files changed, 0 insertions, 0 deletions