diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-09-12 19:12:49 +0200 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-09-18 16:31:37 +0200 |
| commit | f00928012886a07ca6817ea70eb4856ce280ce05 (patch) | |
| tree | 66807da8437bfdb861dfffe4da11bfa1562829c2 /drivers/net/wireless/ti/wl18xx | |
| parent | wifi: rtl8xxxu: Add a description about the device ID 0x7392:0xb722 (diff) | |
| download | linux-f00928012886a07ca6817ea70eb4856ce280ce05.tar.xz linux-f00928012886a07ca6817ea70eb4856ce280ce05.zip | |
wifi: wlcore: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
wlcore_remove() returned zero unconditionally. With that converted to
return void instead, the wl12xx and wl18xx driver can be converted to
.remove_new trivially.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230912171249.755901-1-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/net/wireless/ti/wl18xx')
| -rw-r--r-- | drivers/net/wireless/ti/wl18xx/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ti/wl18xx/main.c b/drivers/net/wireless/ti/wl18xx/main.c index 0b3cf8477c6c..d4a89401f2c4 100644 --- a/drivers/net/wireless/ti/wl18xx/main.c +++ b/drivers/net/wireless/ti/wl18xx/main.c @@ -2033,7 +2033,7 @@ MODULE_DEVICE_TABLE(platform, wl18xx_id_table); static struct platform_driver wl18xx_driver = { .probe = wl18xx_probe, - .remove = wlcore_remove, + .remove_new = wlcore_remove, .id_table = wl18xx_id_table, .driver = { .name = "wl18xx_driver", |