diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2015-08-04 09:42:47 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-07 06:55:47 +0200 |
| commit | a0a2a6602496a45ae838a96db8b8173794b5d398 (patch) | |
| tree | 5508d9f02066c30854b0c88b82fffc03c857adef /drivers/net/xen-netback/netback.c | |
| parent | net: fec: fix initial runtime PM refcount (diff) | |
| download | linux-a0a2a6602496a45ae838a96db8b8173794b5d398.tar.xz linux-a0a2a6602496a45ae838a96db8b8173794b5d398.zip | |
net: Fix skb_set_peeked use-after-free bug
The commit 738ac1ebb96d02e0d23bc320302a6ea94c612dec ("net: Clone
skb before setting peeked flag") introduced a use-after-free bug
in skb_recv_datagram. This is because skb_set_peeked may create
a new skb and free the existing one. As it stands the caller will
continue to use the old freed skb.
This patch fixes it by making skb_set_peeked return the new skb
(or the old one if unchanged).
Fixes: 738ac1ebb96d ("net: Clone skb before setting peeked flag")
Reported-by: Brenden Blanco <bblanco@plumgrid.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Brenden Blanco <bblanco@plumgrid.com>
Reviewed-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback/netback.c')
0 files changed, 0 insertions, 0 deletions