diff options
| author | Jan Beulich <JBeulich@suse.com> | 2016-11-08 08:45:53 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-10 02:24:35 +0100 |
| commit | 6c27f99d35f4d14b7fc5e50ae1f822d7cca6a5af (patch) | |
| tree | 100d6c2f677020bd7fcebd666cd3e4c2ef853421 /drivers/net/xen-netback/xenbus.c | |
| parent | igmp: Document sysctl force_igmp_version (diff) | |
| download | linux-6c27f99d35f4d14b7fc5e50ae1f822d7cca6a5af.tar.xz linux-6c27f99d35f4d14b7fc5e50ae1f822d7cca6a5af.zip | |
xen-netback: prefer xenbus_scanf() over xenbus_gather()
For single items being collected this should be preferred as being more
typesafe (as the compiler can check format string and to-be-written-to
variable match) and more efficient (requiring one less parameter to be
passed).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback/xenbus.c')
| -rw-r--r-- | drivers/net/xen-netback/xenbus.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 8674e188b697..55a4488633e4 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -889,16 +889,16 @@ static int connect_ctrl_ring(struct backend_info *be) unsigned int evtchn; int err; - err = xenbus_gather(XBT_NIL, dev->otherend, - "ctrl-ring-ref", "%u", &val, NULL); - if (err) + err = xenbus_scanf(XBT_NIL, dev->otherend, + "ctrl-ring-ref", "%u", &val); + if (err < 0) goto done; /* The frontend does not have a control ring */ ring_ref = val; - err = xenbus_gather(XBT_NIL, dev->otherend, - "event-channel-ctrl", "%u", &val, NULL); - if (err) { + err = xenbus_scanf(XBT_NIL, dev->otherend, + "event-channel-ctrl", "%u", &val); + if (err < 0) { xenbus_dev_fatal(dev, err, "reading %s/event-channel-ctrl", dev->otherend); |