summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@kernel.org>2008-02-20 01:13:53 +0100
committerJeff Garzik <jeff@garzik.org>2008-02-24 05:57:50 +0100
commitd1e7fe4d92742dd1aa28ca11512628adc79a904b (patch)
tree6e91ec8f67314651601ec968b35c1d9be110b39e /drivers/net
parentigb: Fix panic with NICs with 1000BASE-SX PHY (diff)
downloadlinux-d1e7fe4d92742dd1aa28ca11512628adc79a904b.tar.xz
linux-d1e7fe4d92742dd1aa28ca11512628adc79a904b.zip
net/phy/mdio_bus.c: fix a check-after-use
This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@kernel.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/phy/mdio_bus.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6e9f619c491f..963630c65ca9 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus)
int i;
int err = 0;
- mutex_init(&bus->mdio_lock);
-
if (NULL == bus || NULL == bus->name ||
NULL == bus->read ||
NULL == bus->write)
return -EINVAL;
+ mutex_init(&bus->mdio_lock);
+
if (bus->reset)
bus->reset(bus);