summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-09-01 11:57:40 +0200
committerDavid S. Miller <davem@tempietto.lan>2012-09-02 04:44:13 +0200
commite1b2aa7f3051e268973b6126fdca602ac4af6bc4 (patch)
treea87b24cc2bc7bc4e709bb20b37bc92cd4bf7cc6f /drivers/net
parentnet: ethernet: fix kernel OOPS when remove davinci_mdio module (diff)
downloadlinux-e1b2aa7f3051e268973b6126fdca602ac4af6bc4.tar.xz
linux-e1b2aa7f3051e268973b6126fdca602ac4af6bc4.zip
fddi: 64 bit bug in smt_add_para()
The intent was to set 4 bytes of data so that's why the sp_len is set to 4 on the next line. The cast to u_long pointer clears 8 bytes on 64 bit arches. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@tempietto.lan>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/fddi/skfp/pmf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
index 24d8566cfd8b..441b4dc79450 100644
--- a/drivers/net/fddi/skfp/pmf.c
+++ b/drivers/net/fddi/skfp/pmf.c
@@ -673,7 +673,7 @@ void smt_add_para(struct s_smc *smc, struct s_pcon *pcon, u_short para,
sm_pm_get_ls(smc,port_to_mib(smc,port))) ;
break ;
case SMT_P_REASON :
- * (u_long *) to = 0 ;
+ *(u32 *)to = 0 ;
sp_len = 4 ;
goto sp_done ;
case SMT_P1033 : /* time stamp */