diff options
| author | Moshe Shemesh <moshe@mellanox.com> | 2017-12-04 14:23:51 +0100 |
|---|---|---|
| committer | Saeed Mahameed <saeedm@mellanox.com> | 2017-12-19 22:24:05 +0100 |
| commit | a2fba188fd5eadd6061bef4f2f2577a43231ebf3 (patch) | |
| tree | b0408b584f22a4fd22f0aa583f7c7d7a13381679 /drivers/net | |
| parent | net/mlx5: Cleanup IRQs in case of unload failure (diff) | |
| download | linux-a2fba188fd5eadd6061bef4f2f2577a43231ebf3.tar.xz linux-a2fba188fd5eadd6061bef4f2f2577a43231ebf3.zip | |
net/mlx5: Stay in polling mode when command EQ destroy fails
During unload, on mlx5_stop_eqs we move command interface from events
mode to polling mode, but if command interface EQ destroy fail we move
back to events mode.
That's wrong since even if we fail to destroy command interface EQ, we
do release its irq, so no interrupts will be received.
Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/eq.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index ab4d1465b7e4..e7e7cef2bde4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c @@ -801,11 +801,9 @@ void mlx5_stop_eqs(struct mlx5_core_dev *dev) mlx5_cmd_use_polling(dev); err = mlx5_destroy_unmap_eq(dev, &table->cmd_eq); - if (err) { + if (err) mlx5_core_err(dev, "failed to destroy command eq, err(%d)\n", err); - mlx5_cmd_use_events(dev); - } } int mlx5_core_eq_query(struct mlx5_core_dev *dev, struct mlx5_eq *eq, |