diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2018-12-26 05:23:19 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-12-28 01:23:12 +0100 |
| commit | ff07d48d7bc0974d4f96a85a4df14564fb09f1ef (patch) | |
| tree | 80a92bb3505bba84b31a72a6f81fe4b3bb3719eb /drivers/net | |
| parent | net: dsa: bcm_sf2: Propagate error value from mdio_write (diff) | |
| download | linux-ff07d48d7bc0974d4f96a85a4df14564fb09f1ef.tar.xz linux-ff07d48d7bc0974d4f96a85a4df14564fb09f1ef.zip | |
atl1e: checking the status of atl1e_write_phy_reg
atl1e_write_phy_reg() could fail. The fix issues an error message when
it fails.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index 9dc6da039a6d..3164aad29bcf 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c @@ -473,7 +473,9 @@ static void atl1e_mdio_write(struct net_device *netdev, int phy_id, { struct atl1e_adapter *adapter = netdev_priv(netdev); - atl1e_write_phy_reg(&adapter->hw, reg_num & MDIO_REG_ADDR_MASK, val); + if (atl1e_write_phy_reg(&adapter->hw, + reg_num & MDIO_REG_ADDR_MASK, val)) + netdev_err(netdev, "write phy register failed\n"); } static int atl1e_mii_ioctl(struct net_device *netdev, |