diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-07-08 03:37:43 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-07-10 00:24:33 +0200 |
| commit | 022f09784b85396b4ceba954ce28e50de4882281 (patch) | |
| tree | 380956e32c42ae47fbb22454ca488ceb882ef8a5 /drivers/net | |
| parent | net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable (diff) | |
| download | linux-022f09784b85396b4ceba954ce28e50de4882281.tar.xz linux-022f09784b85396b4ceba954ce28e50de4882281.zip | |
drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable
If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure. Thus this value should not be used after
the end of the iterator. There does not seem to be a meaningful value to
provide to netdev_warn. Replace with pr_warn, since pr_err is used
elsewhere.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/broadcom/cnic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index 3c95065e0def..2c89d17cbb29 100644 --- a/drivers/net/ethernet/broadcom/cnic.c +++ b/drivers/net/ethernet/broadcom/cnic.c @@ -534,7 +534,8 @@ int cnic_unregister_driver(int ulp_type) } if (atomic_read(&ulp_ops->ref_count) != 0) - netdev_warn(dev->netdev, "Failed waiting for ref count to go to zero\n"); + pr_warn("%s: Failed waiting for ref count to go to zero\n", + __func__); return 0; out_unlock: |