diff options
| author | Huang Zijiang <huang.zijiang@zte.com.cn> | 2019-02-14 07:41:45 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-14 18:28:52 +0100 |
| commit | c969c6e7ab8cb42b5c787c567615474fdbad9d6a (patch) | |
| tree | dd9ad92282ea6862fd36a9fa137d99093482605a /drivers/net | |
| parent | mm: page_alloc: fix ref bias in page_frag_alloc() for 1-byte allocs (diff) | |
| download | linux-c969c6e7ab8cb42b5c787c567615474fdbad9d6a.tar.xz linux-c969c6e7ab8cb42b5c787c567615474fdbad9d6a.zip | |
net: hns: Fix object reference leaks in hns_dsaf_roce_reset()
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index 3b9e74be5fbd..b8155f5e71b4 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -3081,6 +3081,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) dsaf_dev = dev_get_drvdata(&pdev->dev); if (!dsaf_dev) { dev_err(&pdev->dev, "dsaf_dev is NULL\n"); + put_device(&pdev->dev); return -ENODEV; } @@ -3088,6 +3089,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) if (AE_IS_VER1(dsaf_dev->dsaf_ver)) { dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n", dsaf_dev->ae_dev.name); + put_device(&pdev->dev); return -ENODEV; } |