diff options
| author | Andre Edich <andre.edich@microchip.com> | 2020-07-06 10:39:35 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-06 21:22:24 +0200 |
| commit | 3ed58f96a70b85ef646d5427258f677f1395b62f (patch) | |
| tree | b173462751b8ddd618c34c8ca6c6f17127fe6d01 /drivers/net | |
| parent | smsc95xx: check return value of smsc95xx_reset (diff) | |
| download | linux-3ed58f96a70b85ef646d5427258f677f1395b62f.tar.xz linux-3ed58f96a70b85ef646d5427258f677f1395b62f.zip | |
smsc95xx: avoid memory leak in smsc95xx_bind
In a case where the ID_REV register read is failed, the memory for a
private data structure has to be freed before returning error from the
function smsc95xx_bind.
Fixes: bbd9f9ee69242 ("smsc95xx: add wol support for more frame types")
Signed-off-by: Andre Edich <andre.edich@microchip.com>
Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/usb/smsc95xx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index eb404bb74e18..bb4ccbda031a 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1293,7 +1293,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) /* detect device revision as different features may be available */ ret = smsc95xx_read_reg(dev, ID_REV, &val); if (ret < 0) - return ret; + goto free_pdata; + val >>= 16; pdata->chip_id = val; pdata->mdix_ctrl = get_mdix_status(dev->net); |