summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorAndrea Merello <andreamrl@tiscali.it>2008-05-10 13:30:12 +0200
committerJohn W. Linville <linville@tuxdriver.com>2008-05-28 22:43:38 +0200
commit0823b2c3c10a4db21cd39a8c72cda96b4dd6d914 (patch)
treeb53f61039d2bf7c6e1ba3ca0ad40ed949aed29e6 /drivers/net
parentrtl8180: avoid NULL dereference in max2820_rf_set_channel (diff)
downloadlinux-0823b2c3c10a4db21cd39a8c72cda96b4dd6d914.tar.xz
linux-0823b2c3c10a4db21cd39a8c72cda96b4dd6d914.zip
rtl8180: fix wrong parameter in sa2400_rf_set_channel
The sa2400 RF code needs to invoke sa2400_write_phy_antenna every time the channel is being switch. This should be done passing the channel number to that function. Incorrectly we were passing the same value that is written on the channel RF register. This may cause problems when operating on ch 14. This patch fixes it. Thanks to Alessandro Di Marco who found this issue! Signed-off-by: Andrea Merello <andreamrl@tiscali.it> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/rtl8180_sa2400.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/rtl8180_sa2400.c b/drivers/net/wireless/rtl8180_sa2400.c
index 0311b4ea124c..cea4e0ccb92d 100644
--- a/drivers/net/wireless/rtl8180_sa2400.c
+++ b/drivers/net/wireless/rtl8180_sa2400.c
@@ -86,7 +86,7 @@ static void sa2400_rf_set_channel(struct ieee80211_hw *dev,
write_sa2400(dev, 7, txpw);
- sa2400_write_phy_antenna(dev, chan);
+ sa2400_write_phy_antenna(dev, channel);
write_sa2400(dev, 0, chan);
write_sa2400(dev, 1, 0xbb50);