diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-08-14 11:06:43 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-08-14 19:03:30 +0200 |
| commit | 6feddb4913011437aaafe34d672aceebdb7c201f (patch) | |
| tree | 83fcb358fabb9ac7c71ae014bdb23271067c0be9 /drivers/net | |
| parent | net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd() (diff) | |
| download | linux-6feddb4913011437aaafe34d672aceebdb7c201f.tar.xz linux-6feddb4913011437aaafe34d672aceebdb7c201f.zip | |
net: dsa: mv88e6xxx: bitwise vs logical bug
We are trying to test if these flags are set but there are some && vs &
typos.
Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 6390")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/dsa/mv88e6xxx/serdes.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c index f007d109b385..e82983975754 100644 --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -502,8 +502,8 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id) err = mv88e6390_serdes_irq_status_sgmii(chip, lane, &status); if (err) goto out; - if (status && (MV88E6390_SGMII_INT_LINK_DOWN || - MV88E6390_SGMII_INT_LINK_UP)) { + if (status & (MV88E6390_SGMII_INT_LINK_DOWN | + MV88E6390_SGMII_INT_LINK_UP)) { ret = IRQ_HANDLED; mv88e6390_serdes_irq_link_sgmii(chip, port->port, lane); } |