diff options
| author | Oliver Neukum <oneukum@suse.com> | 2016-08-17 15:51:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-08-19 08:25:33 +0200 |
| commit | 60bcabd080f53561efa9288be45c128feda1a8bb (patch) | |
| tree | 92bce04e3e38467f5bcbfeded2aa66140adf8e1a /drivers/net | |
| parent | net: bgmac: fix reversed check for MII registration error (diff) | |
| download | linux-60bcabd080f53561efa9288be45c128feda1a8bb.tar.xz linux-60bcabd080f53561efa9288be45c128feda1a8bb.zip | |
kaweth: fix firmware download
This fixes the oops discovered by the Umap2 project and Alan Stern.
The intf member needs to be set before the firmware is downloaded.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/usb/kaweth.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 770212baaf05..37bf715ab53b 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1029,6 +1029,7 @@ static int kaweth_probe( kaweth = netdev_priv(netdev); kaweth->dev = udev; kaweth->net = netdev; + kaweth->intf = intf; spin_lock_init(&kaweth->device_lock); init_waitqueue_head(&kaweth->term_wait); @@ -1139,8 +1140,6 @@ err_fw: dev_dbg(dev, "Initializing net device.\n"); - kaweth->intf = intf; - kaweth->tx_urb = usb_alloc_urb(0, GFP_KERNEL); if (!kaweth->tx_urb) goto err_free_netdev; |