diff options
| author | Tom Rix <trix@redhat.com> | 2020-07-03 15:33:59 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-08 00:23:53 +0200 |
| commit | 28b18e4eb515af7c6661c3995c6e3c34412c2874 (patch) | |
| tree | e82379eabdc7c5c1eef9296ef6d10b38d17b8db9 /drivers/net | |
| parent | cgroup: fix cgroup_sk_alloc() for sk_clone_lock() (diff) | |
| download | linux-28b18e4eb515af7c6661c3995c6e3c34412c2874.tar.xz linux-28b18e4eb515af7c6661c3995c6e3c34412c2874.zip | |
net: sky2: initialize return of gm_phy_read
clang static analysis flags this garbage return
drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
return v;
^~~~~~~~
static inline u16 gm_phy_read( ...
{
u16 v;
__gm_phy_read(hw, port, reg, &v);
return v;
}
__gm_phy_read can return without setting v.
So handle similar to skge.c's gm_phy_read, initialize v.
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/marvell/sky2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 241f00716979..fe54764caea9 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -203,7 +203,7 @@ io_error: static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg) { - u16 v; + u16 v = 0; __gm_phy_read(hw, port, reg, &v); return v; } |