diff options
| author | Tomáš Pilař <tpilar@solarflare.com> | 2015-12-23 09:57:51 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-12-24 04:06:39 +0100 |
| commit | 8c578368e862f6e3055ce5435942e31d72b1cbb2 (patch) | |
| tree | 693674d869f26313d5d62a354e6de7a9f301b270 /drivers/net | |
| parent | sfc: Make failed filter removal less noisy (diff) | |
| download | linux-8c578368e862f6e3055ce5435942e31d72b1cbb2.tar.xz linux-8c578368e862f6e3055ce5435942e31d72b1cbb2.zip | |
sfc: Downgrade EPERM messages from MCDI to debug
When running in an unprivileged function we expect some MC commands
to fail with permission errors. To avoid log spew downgrade these to
debug only.
Signed-off-by: Bert Kenward <bkenward@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/sfc/mcdi.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c index d6b8a77f5b22..d28e7dd8fa3c 100644 --- a/drivers/net/ethernet/sfc/mcdi.c +++ b/drivers/net/ethernet/sfc/mcdi.c @@ -1082,9 +1082,10 @@ void efx_mcdi_display_error(struct efx_nic *efx, unsigned cmd, code = MCDI_DWORD(outbuf, ERR_CODE); if (outlen >= MC_CMD_ERR_ARG_OFST + 4) err_arg = MCDI_DWORD(outbuf, ERR_ARG); - netif_err(efx, hw, efx->net_dev, - "MC command 0x%x inlen %d failed rc=%d (raw=%d) arg=%d\n", - cmd, (int)inlen, rc, code, err_arg); + netif_printk(efx, hw, rc == -EPERM ? KERN_DEBUG : KERN_ERR, + efx->net_dev, + "MC command 0x%x inlen %zu failed rc=%d (raw=%d) arg=%d\n", + cmd, inlen, rc, code, err_arg); } /* Switch to polled MCDI completions. This can be called in various |