diff options
| author | Edward Cree <ecree@solarflare.com> | 2018-03-27 18:44:21 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-27 19:33:20 +0200 |
| commit | 31b842955211f427a099f78a6a63d18a6bbc8d55 (patch) | |
| tree | 5b6b7def288526fdd9d407a14012190bba438f73 /drivers/net | |
| parent | sfc: use a semaphore to lock farch filters too (diff) | |
| download | linux-31b842955211f427a099f78a6a63d18a6bbc8d55.tar.xz linux-31b842955211f427a099f78a6a63d18a6bbc8d55.zip | |
sfc: return a better error if filter insertion collides with MC reboot
If some other operation gets the MCDI lock ahead of us and performs an MC
reboot, then our attempt to insert the filter will fail with EINVAL,
because the destination VI (spec->dmaq_id, MC_CMD_FILTER_OP_IN_RX_QUEUE) does
not exist. But the caller's request (which might e.g. be an ethtool ntuple
request from userland) isn't invalid, it just got unlucky; so return EAGAIN.
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/sfc/ef10.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 9db1b9144e70..9a139c390037 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -4301,6 +4301,7 @@ static s32 efx_ef10_filter_insert(struct efx_nic *efx, bool replace_equal) { DECLARE_BITMAP(mc_rem_map, EFX_EF10_FILTER_SEARCH_LIMIT); + struct efx_ef10_nic_data *nic_data = efx->nic_data; struct efx_ef10_filter_table *table; struct efx_filter_spec *saved_spec; struct efx_rss_context *ctx = NULL; @@ -4427,6 +4428,12 @@ static s32 efx_ef10_filter_insert(struct efx_nic *efx, rc = efx_ef10_filter_push(efx, spec, &table->entry[ins_index].handle, ctx, replacing); + if (rc == -EINVAL && nic_data->must_realloc_vis) + /* The MC rebooted under us, causing it to reject our filter + * insertion as pointing to an invalid VI (spec->dmaq_id). + */ + rc = -EAGAIN; + /* Finalise the software table entry */ if (rc == 0) { if (replacing) { |