summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-06-21 16:40:24 +0200
committerJeff Garzik <jeff@garzik.org>2006-06-23 05:24:18 +0200
commita192491ad58098f2c57d2d1efe721ea0634dc0aa (patch)
tree7a8ef6923e28dcec98f0a6d5bd2c3246cd01eacf /drivers/net
parent[PATCH] Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c (diff)
downloadlinux-a192491ad58098f2c57d2d1efe721ea0634dc0aa.tar.xz
linux-a192491ad58098f2c57d2d1efe721ea0634dc0aa.zip
[PATCH] Array overrun in drivers/net/wireless/wavelan.c
hi, this is another array overrun spotted by coverity (#id 507) we should check the index against array size before using it. Not sure why the driver doesnt use ARRAY_SIZE instead of its own macro. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/wavelan.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/wavelan.c b/drivers/net/wireless/wavelan.c
index dade4b903579..b327b640823b 100644
--- a/drivers/net/wireless/wavelan.c
+++ b/drivers/net/wireless/wavelan.c
@@ -1695,8 +1695,8 @@ static int wv_frequency_list(unsigned long ioaddr, /* I/O port of the card */
/* Look in the table if the frequency is allowed */
if (table[9 - (freq / 16)] & (1 << (freq % 16))) {
/* Compute approximate channel number */
- while ((((channel_bands[c] >> 1) - 24) < freq) &&
- (c < NELS(channel_bands)))
+ while ((c < NELS(channel_bands)) &&
+ (((channel_bands[c] >> 1) - 24) < freq))
c++;
list[i].i = c; /* Set the list index */