diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-10 15:17:29 +0200 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2018-06-11 21:20:59 +0200 |
| commit | 82edcc758f273ed3afd308746dd69376d5b1024d (patch) | |
| tree | 3aa9dfecafb053dfc07a1f2f8673c00fdd30c941 /drivers/ntb/ntb_transport.c | |
| parent | NTB: ntb_hw_idt: fix typo 'can by' to 'can be' (diff) | |
| download | linux-82edcc758f273ed3afd308746dd69376d5b1024d.tar.xz linux-82edcc758f273ed3afd308746dd69376d5b1024d.zip | |
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw
ntb_transport_setup_qp_mw() is never called in atomic context.
ntb_transport_setup_qp_mw() is only called by ntb_transport_link_work(),
which is set as a parameter of INIT_DELAYED_WORK()
in ntb_transport_probe().
Despite never getting called from atomic context,
ntb_transport_setup_qp_mw() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb/ntb_transport.c')
| -rw-r--r-- | drivers/ntb/ntb_transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 9878c48826e3..c848fb3d5099 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -637,7 +637,7 @@ static int ntb_transport_setup_qp_mw(struct ntb_transport_ctx *nt, */ node = dev_to_node(&ndev->dev); for (i = qp->rx_alloc_entry; i < qp->rx_max_entry; i++) { - entry = kzalloc_node(sizeof(*entry), GFP_ATOMIC, node); + entry = kzalloc_node(sizeof(*entry), GFP_KERNEL, node); if (!entry) return -ENOMEM; |