diff options
author | Logan Gunthorpe <logang@deltatee.com> | 2017-08-03 20:19:44 +0200 |
---|---|---|
committer | Jon Mason <jdmason@kudzu.us> | 2017-11-19 02:37:11 +0100 |
commit | 980c41c86b37b6086ad758566b437cb1a469b4bc (patch) | |
tree | c42e292a6364558658a70ce27eb623e138d81ba6 /drivers/ntb/test/ntb_tool.c | |
parent | NTB: switchtec: Add link event notifier callback (diff) | |
download | linux-980c41c86b37b6086ad758566b437cb1a469b4bc.tar.xz linux-980c41c86b37b6086ad758566b437cb1a469b4bc.zip |
NTB: Ensure ntb_mw_get_align() is only called when the link is up
With Switchtec hardware it's impossible to get the alignment parameters
for a peer's memory window until the peer's driver has configured its
windows. Strictly speaking, the link doesn't have to be up for this,
but the link being up is the only way the client can tell that
the other side has been configured.
This patch converts ntb_transport and ntb_perf to use this function after
the link goes up. This simplifies these clients slightly because they
no longer have to store the alignment parameters. It also tweaks
ntb_tool so that peer_mw_trans will print zero if it is run before
the link goes up.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb/test/ntb_tool.c')
-rw-r--r-- | drivers/ntb/test/ntb_tool.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index a69815c45ce6..91526a986caa 100644 --- a/drivers/ntb/test/ntb_tool.c +++ b/drivers/ntb/test/ntb_tool.c @@ -753,9 +753,9 @@ static ssize_t tool_peer_mw_trans_read(struct file *filep, phys_addr_t base; resource_size_t mw_size; - resource_size_t align_addr; - resource_size_t align_size; - resource_size_t max_size; + resource_size_t align_addr = 0; + resource_size_t align_size = 0; + resource_size_t max_size = 0; buf_size = min_t(size_t, size, 512); |