diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-06-19 19:25:14 +0200 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2020-08-24 16:58:06 +0200 |
| commit | b8e2c8bbdf7778c6e3c65db21ababb1dfa794282 (patch) | |
| tree | 4d6c7ae0d1e3ff9a2a1c7983b613e6c29b76289f /drivers/ntb | |
| parent | ntb: intel: Fix memleak in intel_ntb_pci_probe (diff) | |
| download | linux-b8e2c8bbdf7778c6e3c65db21ababb1dfa794282.tar.xz linux-b8e2c8bbdf7778c6e3c65db21ababb1dfa794282.zip | |
NTB: Use struct_size() helper in devm_kzalloc()
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes. Also, remove unnecessary
variable _struct_size_.
This code was detected with the help of Coccinelle and, audited and
fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb')
| -rw-r--r-- | drivers/ntb/test/ntb_msi_test.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c index 99d826ed9c34..7095ecd6223a 100644 --- a/drivers/ntb/test/ntb_msi_test.c +++ b/drivers/ntb/test/ntb_msi_test.c @@ -319,7 +319,6 @@ static void ntb_msit_remove_dbgfs(struct ntb_msit_ctx *nm) static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) { struct ntb_msit_ctx *nm; - size_t struct_size; int peers; int ret; @@ -352,9 +351,7 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) return ret; } - struct_size = sizeof(*nm) + sizeof(*nm->peers) * peers; - - nm = devm_kzalloc(&ntb->dev, struct_size, GFP_KERNEL); + nm = devm_kzalloc(&ntb->dev, struct_size(nm, peers, peers), GFP_KERNEL); if (!nm) return -ENOMEM; |