diff options
| author | Justin Stitt <justinstitt@google.com> | 2023-10-10 01:05:41 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-10-13 11:17:29 +0200 |
| commit | 659ce55fddd2555a75f6ec39fa26c2d10e854263 (patch) | |
| tree | 4fa6e291ac376964387800ee3610107184f4fc76 /drivers/nubus/bus.c | |
| parent | net: mdio: xgene: Use device_get_match_data() (diff) | |
| download | linux-659ce55fddd2555a75f6ec39fa26c2d10e854263.tar.xz linux-659ce55fddd2555a75f6ec39fa26c2d10e854263.zip | |
net: fec: replace deprecated strncpy with ethtool_sprintf
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.
Also, while we're here, let's change memcpy() over to ethtool_sprintf()
for consistency.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/nubus/bus.c')
0 files changed, 0 insertions, 0 deletions