diff options
author | Victor Ding <victording@google.com> | 2020-08-14 11:17:30 +0200 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-08-21 00:10:33 +0200 |
commit | c254bcd7231a3eeafc453f6ee3a483a2e7ff486e (patch) | |
tree | 7f0529705333f96e197e6f23da322bc751f2af26 /drivers/nvdimm/dimm.c | |
parent | Linux 5.9-rc1 (diff) | |
download | linux-c254bcd7231a3eeafc453f6ee3a483a2e7ff486e.tar.xz linux-c254bcd7231a3eeafc453f6ee3a483a2e7ff486e.zip |
rtc: cmos: zero-init wkalrm when reading from CMOS
cmos_read_alarm() may leave certain fields of a struct rtc_wkalrm
untouched; therefore, these fields contain garbage if not properly
initialized, leading to inconsistent values when converting into
time64_t. This patch to zero initialize the struct before calling
cmos_read_alarm().
Note that this patch is not intended to produce a correct time64_t, it
is only to produce a consistent value. In the case of suspend/resume, a
correct time64_t is not necessary; a consistent value is sufficient to
correctly perform an equality test for t_current_expires and
t_saved_expires. Logic to deduce a correct time64_t is expensive and
hence should be avoided.
Signed-off-by: Victor Ding <victording@google.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20200814191654.v2.1.Iaf7638a2f2a87ff68d85fcb8dec615e41340c97f@changeid
Diffstat (limited to 'drivers/nvdimm/dimm.c')
0 files changed, 0 insertions, 0 deletions