diff options
| author | Alexander Duyck <alexander.h.duyck@linux.intel.com> | 2018-10-11 01:39:06 +0200 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2018-10-12 17:39:15 +0200 |
| commit | 19418b024427ec60ba6084addf691a8d93670398 (patch) | |
| tree | a92739838e0700bb092d595c29e1acbb5f583a90 /drivers/nvdimm | |
| parent | nvdimm: Clarify comment in sizeof_namespace_index (diff) | |
| download | linux-19418b024427ec60ba6084addf691a8d93670398.tar.xz linux-19418b024427ec60ba6084addf691a8d93670398.zip | |
nvdimm: Remove empty if statement
This patch removes an empty statement from an if expression and promotes
the else statement to the if expression with the expression logic reversed.
I feel this is more readable as the empty statement can lead to issues if
any additional logic was ever added.
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/label.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c index bb813b8e8ace..43bad0d5bdb6 100644 --- a/drivers/nvdimm/label.c +++ b/drivers/nvdimm/label.c @@ -261,9 +261,8 @@ int nd_label_validate(struct nvdimm_drvdata *ndd) void nd_label_copy(struct nvdimm_drvdata *ndd, struct nd_namespace_index *dst, struct nd_namespace_index *src) { - if (dst && src) - /* pass */; - else + /* just exit if either destination or source is NULL */ + if (!dst || !src) return; memcpy(dst, src, sizeof_namespace_index(ndd)); |