diff options
| author | James Smart <jsmart2021@gmail.com> | 2017-04-26 00:32:01 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-05-20 18:11:34 +0200 |
| commit | 2952a879bacbfae8b03fd886754e64fe14b8041e (patch) | |
| tree | a073545e38bb96561d2ce65401384fe9dbd157f8 /drivers/nvme/host/fc.c | |
| parent | nvme-fc: require target or discovery role for fc-nvme targets (diff) | |
| download | linux-2952a879bacbfae8b03fd886754e64fe14b8041e.tar.xz linux-2952a879bacbfae8b03fd886754e64fe14b8041e.zip | |
nvme-fc: stop queues on error detection
Per the recommendation by Sagi on:
http://lists.infradead.org/pipermail/linux-nvme/2017-April/009261.html
Rather than waiting for reset work thread to stop queues and abort the ios,
immediately stop the queues on error detection. Reset thread will restop
the queues (as it's called on other paths), but it does not appear to have
a side effect.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/nvme/host/fc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 912d457150d5..dca7165fabcf 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -1754,6 +1754,10 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg) dev_info(ctrl->ctrl.device, "NVME-FC{%d}: resetting controller\n", ctrl->cnum); + /* stop the queues on error, cleanup is in reset thread */ + if (ctrl->queue_count > 1) + nvme_stop_queues(&ctrl->ctrl); + if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_RECONNECTING)) { dev_err(ctrl->ctrl.device, "NVME-FC{%d}: error_recovery: Couldn't change state " |