summaryrefslogtreecommitdiffstats
path: root/drivers/nvme
diff options
context:
space:
mode:
authorMark O'Donovan <shiftee@posteo.net>2023-10-11 10:45:12 +0200
committerKeith Busch <kbusch@kernel.org>2023-11-20 18:25:23 +0100
commit38ce1570e2c46e7e9af983aa337edd7e43723aa2 (patch)
tree38304be6ff83da3d1a0961d33f7c87c29ed3d13b /drivers/nvme
parentnvme-auth: unlock mutex in one place only (diff)
downloadlinux-38ce1570e2c46e7e9af983aa337edd7e43723aa2.tar.xz
linux-38ce1570e2c46e7e9af983aa337edd7e43723aa2.zip
nvme-auth: set explanation code for failure2 msgs
Some error cases were not setting an auth-failure-reason-code-explanation. This means an AUTH_Failure2 message will be sent with an explanation value of 0 which is a reserved value. Signed-off-by: Mark O'Donovan <shiftee@posteo.net> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'drivers/nvme')
-rw-r--r--drivers/nvme/host/auth.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index 0f5ea63d3c8d..72c0525c75f5 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -838,6 +838,8 @@ static void nvme_queue_auth_work(struct work_struct *work)
}
fail2:
+ if (chap->status == 0)
+ chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED;
dev_dbg(ctrl->device, "%s: qid %d send failure2, status %x\n",
__func__, chap->qid, chap->status);
tl = nvme_auth_set_dhchap_failure2_data(ctrl, chap);