diff options
| author | Maurizio Lombardi <mlombard@redhat.com> | 2023-01-27 16:42:37 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2023-02-01 14:18:46 +0100 |
| commit | fd62678ab55cb01e11a404d302cdade222bf4022 (patch) | |
| tree | c20351bc08526ced74526ad304c4b54546e70bad /drivers/nvme | |
| parent | nvme-fc: fix a missing queue put in nvmet_fc_ls_create_association (diff) | |
| download | linux-fd62678ab55cb01e11a404d302cdade222bf4022.tar.xz linux-fd62678ab55cb01e11a404d302cdade222bf4022.zip | |
nvme: clear the request_queue pointers on failure in nvme_alloc_admin_tag_set
If nvme_alloc_admin_tag_set() fails, the admin_q and fabrics_q pointers
are left with an invalid, non-NULL value. Other functions may then check
the pointers and dereference them, e.g. in
nvme_probe() -> out_disable: -> nvme_dev_remove_admin().
Fix the bug by setting admin_q and fabrics_q to NULL in case of error.
Also use the set variable to free the tag_set as ctrl->admin_tagset isn't
initialized yet.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 2990ed331a1a..1c333ce64bd4 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4892,7 +4892,9 @@ out_cleanup_admin_q: blk_mq_destroy_queue(ctrl->admin_q); blk_put_queue(ctrl->admin_q); out_free_tagset: - blk_mq_free_tag_set(ctrl->admin_tagset); + blk_mq_free_tag_set(set); + ctrl->admin_q = NULL; + ctrl->fabrics_q = NULL; return ret; } EXPORT_SYMBOL_GPL(nvme_alloc_admin_tag_set); |