diff options
| author | Keith Busch <keith.busch@intel.com> | 2016-02-24 17:15:57 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-03-03 22:42:50 +0100 |
| commit | 63088ec7c8eadfe08b96127a41b385ec9742dace (patch) | |
| tree | bf9ced59312fab61bec342bb406b2367c74040b1 /drivers/nvme | |
| parent | NVMe: Move error handling to failed reset handler (diff) | |
| download | linux-63088ec7c8eadfe08b96127a41b385ec9742dace.tar.xz linux-63088ec7c8eadfe08b96127a41b385ec9742dace.zip | |
NVMe: Don't allow unsupported flags
The command flags can change the meaning of other fields in the command
that the driver is not prepared to handle. Specifically, the user could
passthrough an SGL flag, causing the controller to misinterpret the PRP
list the driver created, potentially corrupting memory or data.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/core.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 7fd5a7ac8375..ba1501514128 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -374,6 +374,8 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio) if (copy_from_user(&io, uio, sizeof(io))) return -EFAULT; + if (io.flags) + return -EINVAL; switch (io.opcode) { case nvme_cmd_write: @@ -425,6 +427,8 @@ static int nvme_user_cmd(struct nvme_ctrl *ctrl, struct nvme_ns *ns, return -EACCES; if (copy_from_user(&cmd, ucmd, sizeof(cmd))) return -EFAULT; + if (cmd.flags) + return -EINVAL; memset(&c, 0, sizeof(c)); c.common.opcode = cmd.opcode; |