diff options
| author | Damien Le Moal <damien.lemoal@opensource.wdc.com> | 2023-03-06 02:13:13 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2023-03-15 14:58:53 +0100 |
| commit | 6173a77b7e9d3e202bdb9897b23f2a8afe7bf286 (patch) | |
| tree | 706cc3488fc991687413ee9496eaea9661fcc29e /drivers/nvme | |
| parent | nvme-trace: show more opcode names (diff) | |
| download | linux-6173a77b7e9d3e202bdb9897b23f2a8afe7bf286.tar.xz linux-6173a77b7e9d3e202bdb9897b23f2a8afe7bf286.zip | |
nvmet: avoid potential UAF in nvmet_req_complete()
An nvme target ->queue_response() operation implementation may free the
request passed as argument. Such implementation potentially could result
in a use after free of the request pointer when percpu_ref_put() is
called in nvmet_req_complete().
Avoid such problem by using a local variable to save the sq pointer
before calling __nvmet_req_complete(), thus avoiding dereferencing the
req pointer after that function call.
Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index f66ed13d7c11..3935165048e7 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -756,8 +756,10 @@ static void __nvmet_req_complete(struct nvmet_req *req, u16 status) void nvmet_req_complete(struct nvmet_req *req, u16 status) { + struct nvmet_sq *sq = req->sq; + __nvmet_req_complete(req, status); - percpu_ref_put(&req->sq->ref); + percpu_ref_put(&sq->ref); } EXPORT_SYMBOL_GPL(nvmet_req_complete); |