diff options
author | Yu Zhao <yuzhao@google.com> | 2014-10-29 22:50:26 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-10-30 00:33:14 +0100 |
commit | 5ddacbe92b806cd5b4f8f154e8e46ac267fff55c (patch) | |
tree | 45394bb991b7403f73ce540ce9add87fa874f350 /drivers/of/of_reserved_mem.c | |
parent | gcov: add ARM64 to GCOV_PROFILE_ALL (diff) | |
download | linux-5ddacbe92b806cd5b4f8f154e8e46ac267fff55c.tar.xz linux-5ddacbe92b806cd5b4f8f154e8e46ac267fff55c.zip |
mm: free compound page with correct order
Compound page should be freed by put_page() or free_pages() with correct
order. Not doing so will cause tail pages leaked.
The compound order can be obtained by compound_order() or use
HPAGE_PMD_ORDER in our case. Some people would argue the latter is
faster but I prefer the former which is more general.
This bug was observed not just on our servers (the worst case we saw is
11G leaked on a 48G machine) but also on our workstations running Ubuntu
based distro.
$ cat /proc/vmstat | grep thp_zero_page_alloc
thp_zero_page_alloc 55
thp_zero_page_alloc_failed 0
This means there is (thp_zero_page_alloc - 1) * (2M - 4K) memory leaked.
Fixes: 97ae17497e99 ("thp: implement refcounting for huge zero page")
Signed-off-by: Yu Zhao <yuzhao@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: David Rientjes <rientjes@google.com>
Cc: Bob Liu <lliubbo@gmail.com>
Cc: <stable@vger.kernel.org> [3.8+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/of/of_reserved_mem.c')
0 files changed, 0 insertions, 0 deletions