diff options
| author | Wan Jiabing <wanjiabing@vivo.com> | 2021-10-15 10:26:58 +0200 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2021-10-20 20:37:25 +0200 |
| commit | f925a97b32f41944c7e03215149be2886d6603b9 (patch) | |
| tree | 9658586d3afeba122799ed004261cb775b137a43 /drivers/of | |
| parent | of: make of_node_check_flag() device_node parameter const (diff) | |
| download | linux-f925a97b32f41944c7e03215149be2886d6603b9.tar.xz linux-f925a97b32f41944c7e03215149be2886d6603b9.zip | |
of/unittest: Add of_node_put() before return
Fix following coccicheck warning:
./drivers/of/unittest.c:3091:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return
Early exits from for_each_child_of_node should decrement the
node reference counter.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015082658.19005-1-wanjiabing@vivo.com
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/unittest.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 8c056972a6dd..b8d2b669408a 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -3094,6 +3094,8 @@ static __init void of_unittest_overlay_high_level(void) if (!strcmp(np->full_name, base_child->full_name)) { unittest(0, "illegal node name in overlay_base %pOFn", np); + of_node_put(np); + of_node_put(base_child); return; } } |