diff options
| author | Jakob Koschel <jakobkoschel@gmail.com> | 2022-03-24 08:18:15 +0100 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2022-04-11 05:01:09 +0200 |
| commit | 95073b721c03c0438b7ee692c20ad2075d3a937a (patch) | |
| tree | 39a215681e86cb0b5fd8022a25ece2247bde78cd /drivers/opp | |
| parent | PM: opp: simplify with dev_err_probe() (diff) | |
| download | linux-95073b721c03c0438b7ee692c20ad2075d3a937a.tar.xz linux-95073b721c03c0438b7ee692c20ad2075d3a937a.zip | |
opp: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.
To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].
This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.
Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/opp')
| -rw-r--r-- | drivers/opp/core.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 2945f3c1ce09..6725ff27c35e 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -1486,9 +1486,8 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_put); */ void dev_pm_opp_remove(struct device *dev, unsigned long freq) { - struct dev_pm_opp *opp; + struct dev_pm_opp *opp = NULL, *iter; struct opp_table *opp_table; - bool found = false; opp_table = _find_opp_table(dev); if (IS_ERR(opp_table)) @@ -1496,16 +1495,16 @@ void dev_pm_opp_remove(struct device *dev, unsigned long freq) mutex_lock(&opp_table->lock); - list_for_each_entry(opp, &opp_table->opp_list, node) { - if (opp->rate == freq) { - found = true; + list_for_each_entry(iter, &opp_table->opp_list, node) { + if (iter->rate == freq) { + opp = iter; break; } } mutex_unlock(&opp_table->lock); - if (found) { + if (opp) { dev_pm_opp_put(opp); /* Drop the reference taken by dev_pm_opp_add() */ |