diff options
| author | Michael Buesch <mb@bu3sch.de> | 2009-07-21 00:58:44 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2009-08-02 12:35:52 +0200 |
| commit | 6b4dbcd86a9d464057fcc7abe4d0574093071fcc (patch) | |
| tree | dd1dc64562db85a382a6118335821c311809cac3 /drivers/parisc/eisa_eeprom.c | |
| parent | parisc: fixed faulty check in lba_pci (diff) | |
| download | linux-6b4dbcd86a9d464057fcc7abe4d0574093071fcc.tar.xz linux-6b4dbcd86a9d464057fcc7abe4d0574093071fcc.zip | |
parisc: isa-eeprom - Fix loff_t usage
loff_t is a signed type. If userspace passes a negative ppos, the "count"
range check is weakened. "count"s bigger than HPEE_MAX_LENGTH will pass the check.
Also, if ppos is negative, the readb(eisa_eeprom_addr + *ppos) will poke in random
memory.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: stable@kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/parisc/eisa_eeprom.c')
| -rw-r--r-- | drivers/parisc/eisa_eeprom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/parisc/eisa_eeprom.c b/drivers/parisc/eisa_eeprom.c index 685d94e69d44..8c0b26e9b98a 100644 --- a/drivers/parisc/eisa_eeprom.c +++ b/drivers/parisc/eisa_eeprom.c @@ -55,7 +55,7 @@ static ssize_t eisa_eeprom_read(struct file * file, ssize_t ret; int i; - if (*ppos >= HPEE_MAX_LENGTH) + if (*ppos < 0 || *ppos >= HPEE_MAX_LENGTH) return 0; count = *ppos + count < HPEE_MAX_LENGTH ? count : HPEE_MAX_LENGTH - *ppos; |